ci: updating release actions to use ubuntu-latest by default #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng sdk-client macos workflow
tanderson-ld
commented
Aug 26, 2024
There was a problem hiding this comment.
Most of this structure comes from https://github.com/launchdarkly/dotnet-client-sdk/blob/main/.github/workflows/publish.yml
Weaved in hash outputs for provenance and using pkgs/sdk/client/github_actions.env to set up env variables to make it more consistent with dotnet-core workflow structure.
kinyoklion
reviewed
Aug 26, 2024
| @@ -0,0 +1,164 @@ | |||
| # This workflow exists because the client sdk build process requires macos. | |||
| name: Manual Publish SDK Client Package | |||
There was a problem hiding this comment.
nit: As we use it with workflow call we may want to remove "manual".
There was a problem hiding this comment.
Leaving this to avoid creating another row in the Github Actions page. Clearing workflows isn't supported without running gh commands.
kinyoklion
reviewed
Aug 26, 2024
kinyoklion
reviewed
Aug 26, 2024
kinyoklion
reviewed
Aug 26, 2024
kinyoklion
reviewed
Aug 26, 2024
kinyoklion
reviewed
Aug 26, 2024
kinyoklion
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the solution you've provided
Updated the release please workflow to use ubuntu-latest runner. Added special case workflow for the client SDK that is brought in from the dotnet-client repo with some modifications. The modifications were to make it work in the dotnet-core workflow/actions structure and to support provenance.